Closed sadikovi closed 6 years ago
@sunchao Could you review this PR as well? Thanks!
@sunchao I updated the code according to your comments. Could you have a look again? Thanks!
I updated the code, could you review again? Let me know if there is anything missing!
Merged. Thanks @sadikovi .
Thanks for merging, @sunchao!
This PR adds
to_thrift
conversion forColumnChunkMetaData
andRowGroupMetaData
, both structs already havefrom_thrift
conversion.I also added builders so metadata can be built outside of
metadata.rs
- this is used in writer when assembling metadata before converting it to Thrift.Note that
build()
methods returnResult
,from_thrift()
methods returnResult
, butto_thrift()
methods returnSelf
directly, because we ensure that metadata is built correctly.Added a few tests to check the conversion.