search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
147 stars 20 forks source link

Apply clippy suggestions #144

Open gnieto opened 6 years ago

gnieto commented 6 years ago

I've ran clippy on the project and it reports some issues. I think it would be nice to apply the suggestions and even ran clippy on CI/Travis.

What do you think?

sunchao commented 6 years ago

+1. I think this will be a good thing to add.

sadikovi commented 6 years ago

Can you be clear if those are issues or suggestions?

sadikovi commented 6 years ago

I just ran it, it reports a bunch of warnings and errors, and a lot of them are false positives. I am not sure we want to do it automatically on every build, but doing it once to fix some of the issues could be beneficial, similar to what we did with style. Cheers!