sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Add RLE encoding to the list of encodings when writing metadata #152

Closed sadikovi closed 6 years ago

sadikovi commented 6 years ago

This PR adds level encoding to the list of Thrift encodings, when we write column chunk metadata. I forgot to include it in my previous PR. It looks like there is no enforced order on encodings - every system out there tries writing in whatever order they want, and format does not enforce it. Here we are following parquet-cpp.

Also removed redundant & operations that I forgot to remove in my previous patch.

sadikovi commented 6 years ago

@sunchao Can you review? Thanks.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 597


Files with Coverage Reduction New Missed Lines %
column/writer.rs 4 94.72%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 596: 0.0004%
Covered Lines: 12023
Relevant Lines: 12592

💛 - Coveralls