sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Add a new data file #154

Closed asdetrefle closed 6 years ago

asdetrefle commented 6 years ago

Added a new data file for benchmark. It contains 41k rows and 21 columns. It is the stocks bid/ask price and qty generated from simulation.

sadikovi commented 6 years ago

How large is the file? If it is too large we could generate it before each benchmark, as we have (almost) all of the functionality to do so now.

Should we update the benchmark as well and post results on PR?

Is it possible to get a breakdown of time spent like the one you mentioned in the related issue?

asdetrefle commented 6 years ago

1.3M is that ok?

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 601


Files with Coverage Reduction New Missed Lines %
encodings/encoding.rs 1 94.82%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 600: -0.008%
Covered Lines: 12049
Relevant Lines: 12618

💛 - Coveralls
sadikovi commented 6 years ago

Should be alright, IMHO.