Closed asdetrefle closed 6 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
encodings/encoding.rs | 1 | 94.82% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 602: | -0.008% |
Covered Lines: | 12049 |
Relevant Lines: | 12618 |
Thanks for the benchmarks! Now we need to figure out what we are going to do to improve the performance.
LGTM
LGTM too. Thanks @asdetrefle !
@sadikovi : I think you should be able to merge this. Can you try it?
@sunchao Yes, I can merge as well! Thanks for the review and sign off. Now, I can help with merging PRs too. @asdetrefle - great job!
The second benchmark test is a for low level column reader call on the new data file. This is theoretically the lower bound of read time needed. We also should aim for this when we implement
Column
andTable
. Now we can see huge potential for the current implementation: