Closed sadikovi closed 5 years ago
Still happens with rustc 1.30.0-nightly (90d36fb59 2018-09-13)
; I will have a look later today.
Yes, parquet 0.3 uses rand 0.4.3 dependency that contains major changes that break the compilation. We patched this in our main repo, that is why cargo install --git https://github.com/sunchao/parquet-rs.git
works (I actually tested on my fork). The fix is releasing a new version on crates.io.
@sunchao Are there any major blockers for releasing parquet 0.4? Or any features you would like to see in that version? Thanks!
One of the solutions here could be using ~X.Y.Z versions in Cargo.toml, instead of X.Y, this would give confidence that no significant changes would affect other libraries or cargo install
.
Thanks @sadikovi !
Yes, parquet 0.3 uses rand 0.4.3 dependency that contains major changes that break the compilation.
Hmm.. how do you know that rand 0.4.3 has backward incompatible changes? I checked their changelog and there's only one fix in that release.
@sunchao Are there any major blockers for releasing parquet 0.4? Or any features you would like to see in that version? Thanks!
Personally I think writer support is the main features for the 0.4 release. I also think we should address some of the performance issue raised recently. Do you have any timeline in mind?
One of the solutions here could be using ~X.Y.Z versions in Cargo.toml, instead of X.Y, this would give confidence that no significant changes would affect other libraries or cargo install.
Yes this can solve this issue. But IMO minor releases should guarantee backward compatibility. Otherwise it will affect lots of downstream clients.
I do not know, really. I just tried installing parquet 0.3 on my machine and got the above error message. I think it is because Rust 1.30 now compiles test fails and they could have been failing in parquet 0.3. Anyway, it will be resolved once we release 0.4.
I don't have any blockers in mind. I was thinking if we could release 0.4 and address performance issues in 0.5.
Sounds good. Releasing 0.4 without the perf issue sounds fine to me as well.
Rust version: rustc 1.30.0-nightly (551244f05 2018-09-10) Parquet version: 0.3 (the latest is released on crates.io) It was working okay in 1.28. I am not sure why it needs to compile files that are used for testing only.
When I run
cargo install parquet
, I get the following error: