search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Parquet-rs 0.3.0 no longer builds with latest Rust nightly #166

Closed andygrove closed 5 years ago

andygrove commented 5 years ago

I can no longer build DataFusion with latest nightly because it depends on parquet-rs 0.3.0 which no longer builds.

I see that the latest code builds fine. Will there be another release soon?

warning: use of deprecated item 'rand::Rand': replaced by distributions::Standard                                
   --> src/data_type.rs:318:29                                                                                   
    |                                                                                                            
318 |     + ::std::clone::Clone + Rand + AsBytes;                                                                
    |                             ^^^^                                                                           

error[E0277]: the trait bound `rand::distributions::Standard: rand::distributions::Distribution<<T as data_type::DataType>::T>` is not satisfied
  --> src/util/test_common.rs:42:9                                                                               
   |                                                                                                             
42 |     rng.gen::<T::T>()                                                                                       
   |         ^^^ the trait `rand::distributions::Distribution<<T as data_type::DataType>::T>` is not implemented for `rand::distributions::Standard`
   |                                                                                                             
   = help: consider adding a `where rand::distributions::Standard: rand::distributions::Distribution<<T as data_type::DataType>::T>` bound

error[E0277]: the trait bound `rand::distributions::Standard: rand::distributions::Distribution<T>` is not satisfied
  --> src/util/test_common.rs:82:21                                                                              
   |                                                                                                             
82 |     result.push(rng.gen::<T>());                                                                            
   |                     ^^^ the trait `rand::distributions::Distribution<T>` is not implemented for `rand::distributions::Standard`
   |                                                                                                             
   = help: consider adding a `where rand::distributions::Standard: rand::distributions::Distribution<T>` bound   

error: aborting due to 2 previous errors
xrl commented 5 years ago

Please try my branch and let me know if it introduces any regressions!

sadikovi commented 5 years ago

Related to https://github.com/sunchao/parquet-rs/issues/160. We just need to release a new version. ping @sunchao. I think the current state of the master is more or less okay for the release. It seems like it could have been caused by changes in rust nightly.

sunchao commented 5 years ago

Yes we should release parquet-rs 0.4 soon. I'll create an issue for this and hopefully can resolve it quickly.

sunchao commented 5 years ago

@andygrove 0.4.0 just released. Can you update the version and let us know if it works now?