Upgraded rand 0.4 -> 0.5

sunchao / parquet-rs

Apache Parquet implementation in Rust

Apache License 2.0

149 stars 20 forks source link

Upgraded rand 0.4 -> 0.5 #167

Closed xrl closed 5 years ago

xrl commented 5 years ago

I was starting a new project with dependencies that dragged in rand 0.5. This was breaking parquet-rs. I don't know the rand library very well but it looks like there has been a change for how the Standard/Distribution work and it creeped in to parquet-rs.

Should fix: https://github.com/sunchao/parquet-rs/issues/166 And should answer my question at: https://github.com/rust-random/rand/issues/626

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 628

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 94.768%

Totals
Change from base Build 624:	-0.8%
Covered Lines:	634
Relevant Lines:	669

💛 - Coveralls

xrl commented 5 years ago

Hey, thanks for the thorough review. All great feedback, I was definitely a little sloppy while hacking on this. I agree, it doesn't make sense that just having a mix of rand 0.4 and rand 0.5 in a project would cause an issue, but the type errors made me think it was a mix up. In any case, maybe this is just helpful in general to the project.

sunchao commented 5 years ago

Merged. Thanks @xrl for the PR and @sadikovi for the review!