search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
147 stars 20 forks source link

API has changed but README is not updated and there are no examples #175

Closed andygrove closed 6 years ago

andygrove commented 6 years ago

In DataFusion I have updated to 0.4.1 but my code no longer compiles:

36 |     reader: SerializedFileReader,                                                                                 
   |             ^^^^^^^^^^^^^^^^^^^^ expected 1 type argument

I cannot easily find examples of what I need to do. The README is not updated and there are no examples in the repo.

I will go and look in the codebase and try and figure this out but this issue is more about docs/examples being available than the issue itself.

andygrove commented 6 years ago

I take it back .. the call to create it hadn't changed but the return type had

I needed SerializedFileReader<File> now instead of SerializedFileReader