search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Fix Parquet version "created by" string #176

Closed sadikovi closed 5 years ago

sadikovi commented 5 years ago

Currently, because of my patch that introduced the regression and was subsequently reverted, parquet version (created by field) is something like parquet-rs version X.Y.Z. But it is generally accepted to have version in the following format parquet-rs version X.Y.Z (build {git hash}).

I will think about the ways of fixing it, but something tells me that we should have a separate script to substitute the versions as part of the release.

sadikovi commented 5 years ago

I am going to close this ticket. I don't think we should do any follow-up.