Support unsigned types and timestamp millis in record reader

sunchao / parquet-rs

Apache Parquet implementation in Rust

Apache License 2.0

149 stars 20 forks source link

Support unsigned types and timestamp millis in record reader #181

Closed sadikovi closed 5 years ago

sadikovi commented 5 years ago

This PR adds support for the following logical types for the record reader API:

INT32 physical type
- UINT_8
- UINT_16
- UINT_32
INT64
- TIMESTAMP_MILLIS
- UINT_64

I named the new fields as UByte, UShort, UInt and ULong. I know, these names are not the best, but I can't change the existing API to make them all conform to either INT_XY or UINT_XY.

I also updated accessors' methods and updated unit tests.

Relates to #178.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 645

0 of 0 changed or added relevant lines in 0 files are covered.
20 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 95.536%

Files with Coverage Reduction	New Missed Lines	%
record/api.rs	20	97.24%
<!--	Total:	20		-->

Totals
Change from base Build 640:	0.02%
Covered Lines:	12477
Relevant Lines:	13060

💛 - Coveralls

sunchao commented 5 years ago

Merged. Thanks @sadikovi !

sadikovi commented 5 years ago

Thanks! It is not the best change, but I could not find better names for the new types.