search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Apply rustfmt? #187

Closed sunchao closed 5 years ago

sunchao commented 5 years ago

This has been discussed long time back (see #44). As we have more people contributing to the project now, I wonder if we should revisit this, provide a rustfmt template and check it in CI. Personally, I had some good experiences with rustfmt in other projects, as well as similar stuff in Go. @sadikovi : want to hear you opinion on this.

sadikovi commented 5 years ago

Sounds good. My only worry is that all rules are applied in all or nothing fashion, I could not manage to make it work with only a subset of rules. If there is a way to do it now or there are no objections to applying all rules, then let’s add it.

sunchao commented 5 years ago

Yes it is all or nothing, which means we need a giant commit to fix all the existing style violations. Personally I'm fine with that. I'll add a PR for the rules & results.

sadikovi commented 5 years ago

Okay, thanks.