Closed sadikovi closed 5 years ago
How come we did not see the failure earlier? Does CI run benchmarks?
How come we did not see the failure earlier? Does CI run benchmarks?
CI does run the benchmark. It's at the bottom of the output, and you'll need to expand it to examine. Seems the benchmark started to fail since the int96 code change.
Merged. Thanks @sadikovi !
Thanks!
This PR tries to mitigate the failure in
record_reader_10k_collect
benchmark by passing projection that excludes Int96 column. The error that I got was:I simply pass projection on every iteration of the benchmark. Unfortunately this adds an overhead of parsing the string into schema every time we run benchmark, but IMHO it is negligible compared to actual reading of records.
I will revert the patch once Int96 conversion works correctly for negative timestamps.
The benchmark runs after the patch.
Closes #201