Update parquet.thrift - Githubissues

sunchao / parquet-rs

Apache Parquet implementation in Rust

Apache License 2.0

149 stars 20 forks source link

Update parquet.thrift #28

Closed sadikovi closed 6 years ago

sadikovi commented 6 years ago

This PR updates parquet.thrift file to the latest version in parquet-format f1de77d31936f4d50f1286676a0034b6339918ee (https://github.com/apache/parquet-format/commit/f1de77d31936f4d50f1286676a0034b6339918ee). All tests pass locally after I added missing codec types LZ4 and ZSTD.

Closes #21

sadikovi commented 6 years ago

@sunchao Could you review please? Thanks!

I simply copied format to the repository. There are quite a few changes to the format itself with additions like column index, etc. For example, there is added LogicalType to replace ConvertedType. Do we need to add support for it?

sadikovi commented 6 years ago

We should also create issues to add those LZ4 and ZSTD support!

coveralls commented 6 years ago

Coverage increased (+4.7%) to 94.586% when pulling d6604d2a90b4b28320d21f2295a02050ce8b61b4 on sadikovi:update-parquet-format into 98e21bae9b599ffc7cd75e9ee5df4233636e6053 on sunchao:master.

coveralls commented 6 years ago

Coverage increased (+4.8%) to 94.632% when pulling 54470703fc2cf212dfa47f71ede5f097445bd50b on sadikovi:update-parquet-format into 98e21bae9b599ffc7cd75e9ee5df4233636e6053 on sunchao:master.

sadikovi commented 6 years ago

@sunchao I addressed your comments. Could you have a look again? Thanks!

sunchao commented 6 years ago

Merged. Thanks again @sadikovi !

sadikovi commented 6 years ago

@sunchao thanks for the review and merge!