search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Add tests #29

Closed sadikovi closed 6 years ago

sadikovi commented 6 years ago

This PR adds a few simple tests for file/reader.rs and encoding/decoding.rs and makes minor updates to error messages.

sadikovi commented 6 years ago

@sunchao Could you have a look at this PR? Thanks!

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.9%) to 95.474% when pulling ac99a1d5567ea9fec980e0c214f5361d6ec41cb8 on sadikovi:file-reader-tests into 4b00ef380d777363f545e7040399ac3a6a202167 on sunchao:master.

sadikovi commented 6 years ago

@sunchao I removed lifetime parameter from both test helper methods. Looks like it works.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.9%) to 95.474% when pulling 4dd172be8690037ff4748ee44d16dd1a54785ee4 on sadikovi:file-reader-tests into 4b00ef380d777363f545e7040399ac3a6a202167 on sunchao:master.

sunchao commented 6 years ago

Merged. Thanks @sadikovi !

sadikovi commented 6 years ago

Thanks @sunchao for reviewing and merging!