search

sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Remove lifetime from column reader #65

Closed sadikovi closed 6 years ago

sadikovi commented 6 years ago

This PR removes 'a lifetime from ColumnReader and ColumnReaderImpl. It looks like we may not need it, and it also helps solving problem of returning a global iterator of records.

sadikovi commented 6 years ago

@sunchao Could you review this PR when you have time? Thanks! As discussed, here we remove 'a from column reader.

sadikovi commented 6 years ago

Thanks!