Closed sadikovi closed 7 years ago
@sunchao Could you review this PR? I would like to help with this project, if possible (though I am new to Rust). Thanks.
Thanks @sadikovi for your interest in this project. PRs are definitely welcome! I left a minor comment but overall the code looks good.
@sunchao Thanks for reviewing PR. I answered your question regarding enable-libs
- honestly, do not know how to disable them all and enable certain ones - would appreciate your help.
Also do you think I should change titles in README, e.g. Development
and etc.? Thanks.
Also do you think I should change titles in README, e.g. Development and etc.? Thanks.
Yes a Development
section is fine to me.
@sunchao I updated README file. Could you have a look again? Thanks!
Merged. Thanks!
Thanks for merging pull request!
This PR adds build instructions for the project. I have spent a considerable amount of time trying to build Thrift and etc., so I hope this will be useful for other people.
Also
make clean
is updated to remove generated files fromsrc/parquet_thrift
.