sunchao / parquet-rs

Apache Parquet implementation in Rust
Apache License 2.0
149 stars 20 forks source link

Fix make clean and build instructions #9

Closed sadikovi closed 7 years ago

sadikovi commented 7 years ago

This PR adds build instructions for the project. I have spent a considerable amount of time trying to build Thrift and etc., so I hope this will be useful for other people.

Also make clean is updated to remove generated files from src/parquet_thrift.

sadikovi commented 7 years ago

@sunchao Could you review this PR? I would like to help with this project, if possible (though I am new to Rust). Thanks.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.859% when pulling ab3bbfa69fc4520cab44f77cff8faf62022540ec on sadikovi:update-readme into 2b36c4a2b87f5d831e2fc95f00598b681258ebb2 on sunchao:master.

sunchao commented 7 years ago

Thanks @sadikovi for your interest in this project. PRs are definitely welcome! I left a minor comment but overall the code looks good.

sadikovi commented 7 years ago

@sunchao Thanks for reviewing PR. I answered your question regarding enable-libs - honestly, do not know how to disable them all and enable certain ones - would appreciate your help.

Also do you think I should change titles in README, e.g. Development and etc.? Thanks.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 83.859% when pulling f684c89bbf34d999bf21b529ac2df320181b3e99 on sadikovi:update-readme into 2b36c4a2b87f5d831e2fc95f00598b681258ebb2 on sunchao:master.

sunchao commented 7 years ago

Also do you think I should change titles in README, e.g. Development and etc.? Thanks.

Yes a Development section is fine to me.

sadikovi commented 7 years ago

@sunchao I updated README file. Could you have a look again? Thanks!

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 83.885% when pulling 30e6da679acc92623d346ec4a6496ccccd48ae3a on sadikovi:update-readme into 2b36c4a2b87f5d831e2fc95f00598b681258ebb2 on sunchao:master.

sunchao commented 7 years ago

Merged. Thanks!

sadikovi commented 7 years ago

Thanks for merging pull request!