search

sundaewaffle / sipvicious

Automatically exported from code.google.com/p/sipvicious
0 stars 0 forks source link

.sipvicious settings should be in a homedirectory #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The tool creates ".sipvicious" folder in a current folder for some reason.

I'm no export in python, here is the quick patch
http://code.google.com/p/pentoo/source/browse/portage/trunk/net-analyzer/sipvici
ous/files/sipvicious-0.2.8-path.patch

Original issue reported on code.google.com by blshkv on 12 Dec 2012 at 2:56

GoogleCodeExporter commented 9 years ago 
thanks for the patch =) the tools were meant to be run in one directory and 
everything would be in that place. But yea it might make sense to just use the 
$HOME. I'll commit

Original comment by san...@enablesecurity.com on 12 Dec 2012 at 3:11

GoogleCodeExporter commented 9 years ago 
You are welcome ;-) The "cleaner" patch would be to get rid of the .join 
operator by replacing it something like:
sessionpath=os.path.expanduser('~')+'.sipvicious'+sessiontype
but I'm not sure if it would work.

btw, you can also move that function to the library and create a global 
variable, instead of detecting the path every (like 20) time you need it.

Original comment by blshkv on 13 Dec 2012 at 2:27

GoogleCodeExporter commented 9 years ago 
os.path.join is useful because it is OS independent and considered a clean way 
to do this. I prefer to use that. 

That said, there's so many ways to improve the code quality of sipvicious ;-) 
Which is one of the reasons (not the only) why I started a rewrite..

Original comment by san...@enablesecurity.com on 14 Dec 2012 at 11:56

GoogleCodeExporter commented 9 years ago

Original comment by san...@enablesecurity.com on 27 Dec 2012 at 5:34