suned
commented
3 years ago You are quite right, but it might not be straight forward to improve. The main reason it takes a long time is https://pypi.org/project/pytest-mypy-plugins/ since I've had to disable mypy caching when testing because the plugin tests would occasionally crash when trying to read from the mypy cache. Even with caching disabled, this error sometimes occur when running tests in parrallel using pytest xdist, which means that xdist has also been disabled making them even slower. Perhaps this issue is fixed in newer versions of pytest-mypy-plugins, in which case this would improve the situation by a margin.
Moreover, tox is setup to run tests for both python 3.7 and 3.8, which is probably not necessary to do during local development. You can run a single test environment using tox -e py37 for example which cuts the time in half. You can probably also skip the mypy plugin tests in local development and enable xdist using pytest -p no:pytest-mypy-plugins -n 4 . That command takes about 27 seconds on my machine.
If you are only changing things related to a specific type like Effect or List it should be enough to run only the tests for that type locally, and only run the entire test suite on circleci. Hope this helps.
I'll keep the issue open as a reminder to look into upgrading pytest-mypy-plugin
thomhickey
The test suite takes so long to run that I probably wouldn't run it very frequently. I'm not sure if this is because of tox or if it's the tests themselves, I haven't looked into it in detail but it makes writing tests quite tedious.