sunfishcode / c-ward

An implementation of libc written in Rust
Other
187 stars 11 forks source link

Add finite and lgamma #105

Closed KGrewal1 closed 7 months ago

KGrewal1 commented 7 months ago

This adds the functions described in https://man7.org/linux/man-pages/man3/isnanf.3.html for f32 and f64 removing isnanf() from todo.

Implemented are

and the missing maths functions

-lgamma -lgammaf It also cleans up strcmp and strverscmp such that the break conditions are in the while condition

KGrewal1 commented 7 months ago

I've just realised that lgamma and lgammaf are already in libm (and so I can add them to this PR if that suits as opposed to many more PRs)?

sunfishcode commented 7 months ago

Yeah, adding them to this PR is fine for now.

sunfishcode commented 7 months ago

Looks great, thanks!