search

sunflower-land / sunflower-land

1.54k stars 599 forks source link

[BUG] [Goblin Retreat] OpenSea link to view Resale items opens in the same browser tab #1907

Closed johannesunana closed 1 year ago

johannesunana commented 1 year ago

Summary of Bug

Clicking the View Items on Open Sea button on Resale in Goblin Retreat opens the OpenSea Sunflower Land Collectibles webpage in the same tab.

Steps to Reproduce

  1. Open Sunflower Land. Click the boat to travel to Goblin Retreat.
  2. Click Resale and wait for the popup to appear.
  3. Click the View Items on Open Sea button.
  4. Browser goes to https://opensea.io/collection/sunflower-land-collectibles in the same tab.

Expected Behavior

The link to OpenSea Sunflower Land Collectibles in Resale should open in a new browser tab. Similar to Go to Bumpkins.io in Wearables.

Actual Behavior

OpenSea Sunflower Land Collectibles opens in the same tab. The player leaves the Sunflower Land domain, requiring players to reconnect their wallet to re-access their farm.

Screenshots/Recording

Resale Goblin Retreat

https://user-images.githubusercontent.com/99703415/208668345-87b3eccf-db0f-4fde-af81-5a168191f2c1.mp4

Device Information:

Polysemouse commented 1 year ago

This is fixed by https://github.com/sunflower-land/sunflower-land/pull/1871

johannesunana commented 1 year ago

Hello @hujikol is this bug part of your fix? I did a hard refresh after Adam made two merges earlier today, and the bug is still there. Thanks.

hujikol commented 1 year ago

Yes it is also included in my pr here #1871 , it was merged but not yet live/ released to the game

Edit: you can close this issue for now