search

sunflowerdeath / webfonts-generator

Generator of webfonts from svg icons
The Unlicense
271 stars 152 forks source link

baseSelector instead of baseClass for template options. #12

Closed zaucy closed 7 years ago

zaucy commented 8 years ago

I changed the template options baseClass to baseSelector for more flexibility. baseClass can still be used, but it gives a warning for using it.

In a project I'm working on we use our base selector for our icon font something similar to [class^=icon-] so using baseClass didn't work for us. I did use a hack specifying baseClass something similar to icon, [class^=icon-], but I don't like hacky solutions.

CXHtml commented 7 years ago

Hi, I'm not sure whether you guys have encountered this case:

I just set the baseSelector as [class^=icon-], but the output from res.generateCss method is like [class^=icon-]. It seems something wrong with the hbs parser?

CXHtml commented 7 years ago

I think for baseSelector in css.hbs, we should use "triple-stash" to fully escape the html syntax, i.e use {{{baseSelector}}} instead