search

sunflowerdeath / webfonts-generator

Generator of webfonts from svg icons
The Unlicense
271 stars 152 forks source link

HTML template does not work with new baseSelector option #20

Open bartvanandel opened 7 years ago

bartvanandel commented 7 years ago

As the title implies, the HTML template still requires the now deprecated 'baseClass' option. With the 'baseSelector' option, the generated HTML file renders incorrectly due to missing classes. As the 'baseClass' option is converted into a 'baseSelector' value, it now always fails.

Ex: output from previous version, using 'baseClass' = 'glyphicon':

<span class="glyphicon novaicon-add-circle-1"></span>

New version, using using 'baseSelector' = '.glyphicon' (or same 'baseClass' as before), outputs:

<span class=" novaicon-add-circle-1"></span>
saulyz commented 6 years ago

Problem still persists. So it is hard to see webfont preview in html

nkamate commented 6 years ago

Still seeing this issue.