search

sunflowerdeath / webfonts-generator

Generator of webfonts from svg icons
The Unlicense
271 stars 152 forks source link

Significantly Outdated Dependency and Sub-Dependency #40

Open bdjnk opened 6 years ago

bdjnk commented 6 years ago

The current "version": "0.4.0" of webfonts-generator includes "svgicons2svgfont": "^5.0.0", whose latest minor version is six months old. They're currently at "version": "8.0.0".

Worse still, "svgicons2svgfont": "^5.0.0" appears to be including "svg-pathdata": "^1.0.4", which is a year old. They're currently at "version": "4.0.1".

All this is important to me because bugs have cropped up for me in svg-pathdata while using icon-font-generator (which uses webfonts-generator) and I can't tell if the problems might be resolved simply by being up to date.

markadrake commented 6 years ago

I forked the repo and updated the dependencies, then ran the tests. The tests passed, except for a small issue with the RENDERED_TEMPLATE having a return character \r before the newline. I updated the test too so that it passed. The only other update I had to make was calling svgicons2svgfont with new.

Mind testing it out? Should anything else be done before submitting a PR?

https://github.com/markadrake/webfonts-generator/commit/387029ee051a181a1740177ca5eea7d64ee58fe2

bdjnk commented 6 years ago

I've tested your fork on my set of SVGs. No errors presented and the bugs I was experiencing have evidently been resolved.

Thank you @markadrake!

markadrake commented 6 years ago

You are very welcome @bdjnk. It also resolved some quirks I noticed with my own SVG icons.

Wondering how to push the PR forward though - not a lot of experience on my end committing to public open source projects like this. Any tips or suggestions? Looks like part of the reason my PR failed was due to some outdated node versions so that's immediately a major release. I get that, but no response from the maintainer :/