Upgrade of Dependencies

sunflowerdeath / webfonts-generator

Generator of webfonts from svg icons

The Unlicense

271 stars 152 forks source link

Upgrade of Dependencies #41

Closed markadrake closed 1 year ago

markadrake commented 6 years ago

Primarily would like to upgrade dependencies for continued troubleshooting of the SVG -> font conversion. I get unexpected results. After searching for best practices I landed across issue #40 and decided to upgrade some of the packages. There are major upgrades below.

There is 1 update to the tests because of a \r character I kept receiving. So I updated the conditions of the test to allow it to pass.

There is 1 update in the source code where new had to be used.

markadrake commented 6 years ago

Seems like svgicons2svgfont@8.0.0 doesn't support anything less than node v6.9.5. So CI failed for these versions.
And the update I made to account for the \r character in the test (node v8.6.0) fails in node v6.12.3. I can at least research this one.

TrevorKarjanis commented 6 years ago

I would be great if we could get these dependency updates merged, and update the npm package. There are other changes missing upstream like updates to the HTML template.