sunflowerit / waftlib

Apache License 2.0
7 stars 14 forks source link

[ADD] additional out-of template requirements for special modules #10

Closed gfcapalbo closed 2 years ago

gfcapalbo commented 2 years ago

@thomaspaulb don;t know if im using this right, but i needed an additional pip installation of acme, dnspython in the project to get it working. these libs are not in the requirements.txt template of waft10 and i thought that changing the template just for letsencrypt libraries was a bad idea.

so i changed build to also install libs in the optional file "extra requirements.txt", and it won't fail if file does not exist.

If there was a better way , ignore and point me to the right way.

Hussam-Suleiman commented 2 years ago

@gfcapalbo if extra_requirements.txt does not exist we will get an error by adding ( ; ) you broke ( && ) chain requirements.txt is just a link to a template file, you can break the link, copy the template to the main working directory, edit the file to add pip packages that you want to install as extra modules

I think it is not necessarily to add extra_requirements.txt file

Regards

thomaspaulb commented 2 years ago

Agreed with @Hussam-Suleiman - if a project deviates from the standard then just remove symlink to default requirements.txt, copy it as a real file, modify, commit.

Regarding acme and dnspython, I gather they're used for Therp's letsencrypt Odoo module - but we don't need that in the container hosting system, since we're doing the certificates with either certbot or acme.sh in the nginx-server container.

gfcapalbo commented 2 years ago

@hussam tom explained the correct way to do this in waft. closing.

also i had misunderstood the chaining of ";" operator. now clear....