sunflowerit / waftlib

Apache License 2.0
7 stars 14 forks source link

[IMP] Add datadir to .gitignore #22

Closed NL66278 closed 1 year ago

NL66278 commented 1 year ago

Having a data directory inside an Odoo instance based on waft makes it easy to have self-contained deployments, which is especially handy for local development environments.

This change just enables a local data directory, it changes nothing in the default installation location.

thomaspaulb commented 1 year ago

What kind of files would you put there? I have nothing against this change so LGTM, @Hussam-Suleiman if you also don't mind just merge.

Hussam-Suleiman commented 1 year ago

@thomaspaulb I think it is for filestore directory @NL66278 the long answer is: it is okay for me if you like to use this way in your laptop, but not in the containers in our servers, because it is not a variable in our system yet, and for all containers in our system, we use the default path (${Home}/.local/share/Odoo/filestore/) and we use this path in nightly scripts and in backups rules and in ansible too, so, I will merge it, but, don't use it in our containers until we update our system to have this feature. the short answer: accepted in personal use.

NL66278 commented 1 year ago

@thomaspaulb @Hussam-Suleiman It is indeed for personal use.

I have data_dir = ${ODOO_WORK_DIR}/datadir in common/conf.d/test-odoo.cfg

In my $HOME directory I have a directory projecten (projects). For each customer / project I have a waft deployment branch under that directory. If a project is no longer needed, I can just rm -fr the whole thing and be done with it. I is also easier to maneuver between the data directory and the other directories in the project.

thomaspaulb commented 1 year ago

You'll still have to dropdb the database though

Hussam-Suleiman commented 1 year ago

@NL66278 it is a good idea to make waft more flexible, I moved the ignored directory in waft repository because here will not effect the main folder.

Regards!

NL66278 commented 1 year ago

You'll still have to dropdb the database though

I know ;-)