Closed KKamaa closed 1 year ago
@KKamaa in theory, we can and it easy. in fact, we can, and it does not easy, and it has a risk because I think that we already have now more than 50 waft production repositories, and we have trusted python 3.6.15 until now, if we need to upgrade it to 3.7 we should be sure it works fine, and we should test it for a few projects first, or, you can share your reasons first, then we can investigate about it more
@thomaspaulb what do you think?
oh ok cool, some functionalities keep being updated in newer versions not to forget about bug fixes just like any software.So maybe not now, but we could take advantage of new functionalities and also be secure from bugs you can check which is the most stable version currently. Anyway it was just a thought, cause I had an issue with debugger that was sorted by upgrading the python version.
Some things to keep in mind:
requirements.txt
should change as well, so it's not so easy to doI think we shouldn't bother to change the Python version for Waft below 14.0. For 14.0 maybe we can go to 3.8, but we should test it properly first. For 15.0 we can use Python 3.8, and for 16.0 we can use Python 3.10
@KKamaa If you want to change a Python version for a project, you can just do so yourself, by changing .python-version
and modifying requirements.txt
, and then deleting .pyenv
and .venv
and re-running ./bootstrap
and ./build
. If you can get it to work, you can test it out on test server, and then we can adjust it in production as well if it works, and THEN we can apply it in waft templates maybe.
I would say it makes sense to update some of our 14.0 instances to Python 3.8.16 though, and if that works well, update the 14.0 template. What do you think @Hussam-Suleiman ?
@thomaspaulb years ago we had Doodba on ubuntu 18.04, and we used the default ubuntu python version for Odoo from version 11.0 to version 14.0, now we have a fully isolated virtual python version environment, so, if python version 3.8.16 working fine for Odoo version 14.0 we can apply it by default, just we need to be sure that we don't have incompatible codes in our Odoo 14.0 codes, so, yes we can apply it for Therp helpdesk and Freshfilter test instances and then if it works well we can apply it by default to the productions.
@Hussam-Suleiman @thomaspaulb could we upgrade the version of python in waftlib templates from 3.6.15 to at least >= 3.7