search

sunflowerit / waftlib

Apache License 2.0
7 stars 14 forks source link

[ADD] #9500 Added the migration script to waft. #29

Open ddejong-therp opened 1 year ago

ddejong-therp commented 1 year ago

I've added the migration script to waftlib. Not 100% sure if the placement of files/directories is in line with the conventions. But that can always be changed of course.

Another thing I still like to change, is the fact that currently the builds of the migration are build when you use the -r switch in the migration script. However, maybe it is more nice if that is included into the ./build script. Maybe the build script can detect whether a migration is enabled in .env-*, and if so, set up the intermediate migration builds as well. Perhaps I can still do this once the clouds clear up and I have some time. :)

thomaspaulb commented 1 year ago

@ddejong-therp I also see one conflict, can you rebase?

thomaspaulb commented 1 year ago

Another thing I still like to change, is the fact that currently the builds of the migration are build when you use the -r switch in the migration script. However, maybe it is more nice if that is included into the ./build script.

Personally I would keep this separate, so that we decrease the risk of improvements in our migration script causing regressions with the ./build command of other Waft instances.

ddejong-therp commented 1 year ago

Another thing I still like to change, is the fact that currently the builds of the migration are build when you use the -r switch in the migration script. However, maybe it is more nice if that is included into the ./build script.

Personally I would keep this separate, so that we decrease the risk of improvements in our migration script causing regressions with the ./build command of other Waft instances.

yeah that's fair.