search

sunflowerit / waftlib

Apache License 2.0
7 stars 14 forks source link

Master depth calculation #38

Closed gfcapalbo closed 1 year ago

gfcapalbo commented 1 year ago

Before building we run an update_depth script.

This is made to keep depths in waft updated. If build is on it's first run the check will not happen.

Deployed and testing on our internal nightly instance.

gfcapalbo commented 1 year ago

@gjotten @Hussam-Suleiman requested changes done

Hussam-Suleiman commented 1 year ago

for now, I will merge the changes to master, and in same time I am working to upgrade it to the new version https://github.com/sunflowerit/waftlib/blob/v.23.08.03/.python-files/waft-update-depths .

Hussam-Suleiman commented 1 year ago

@gfcapalbo it does not work for odoo 8 with python 2.7, did you test it with all odoo versions? image

Hussam-Suleiman commented 1 year ago

after I merged this changes and then removed it from master again, I can't open this pull request again, @gfcapalbo do you have any idea?

Hussam-Suleiman commented 1 year ago

@gfcapalbo @gjotten @NL66278 sorry for destroyed this pull request, we will continue on https://github.com/sunflowerit/waftlib/pull/40

gfcapalbo commented 9 months ago

@Hussam-Suleiman replaced with MR: https://github.com/sunflowerit/waftlib/pull/41

I have added an exit , if python version is not >= 3.5. Script will just add a line "Depth update not supported for python < 3.5".

it was easier to manage it this way instead of writing a lot of different code to support python 2.7 wich is deprecated.

gfcapalbo commented 9 months ago

@Hussam-Suleiman re-tested. now script will exit when python is < 3.5 and the depth calculation will not be supported for older projects.... the error you had will not appear anymore.