search

sunflowerit / waftlib

Apache License 2.0
7 stars 14 forks source link

Master depth calculation #41

Open gfcapalbo opened 9 months ago

gfcapalbo commented 9 months ago

replaces, https://github.com/sunflowerit/waftlib/pull/40 , wich was created by hussam after reverting . PYTHON < 3.5 NOT SUPPORTED. (will exit doing nothing) subprocess.run was instroduced in that version. tested on python 2.7 and 3.10.

If ran on 2.7, it will produce a message warning user "automatic update depth not supported for python < 3.5" and continue normal execution.

gfcapalbo commented 9 months ago

CC @thomaspaulb @Hussam-Suleiman your message about multiple version supported should not be a problem. this MR adds automatic depth calculations for python 3.5 and above. for lower versions it just prints a message "no automatic depth supported".

Supporting python <3 would require a lot of coding , which i think is not warranted to support deprecated python versions. it does not harm py 2.X projects.