search

sunflowerit / waftlib

Apache License 2.0
7 stars 14 forks source link

New `./migrate` script issues #42

Closed ddejong-therp closed 9 months ago

ddejong-therp commented 9 months ago

I see there are some changes to the ./migrate script. However, the $ODOO_START_FROM_VERSION is just set to $ODOO_VERSION. But $ODOO_VERSION is the 'destination' version. The root waft build is of the destination/target odoo build.

The migration script in ./waftlib/bin/migrate.py is built to use the environment variable $MIGRATION_START_VERSION for the start version, and $ODOO_VERSION as the target/destination version. The names of these variables can be changed of course, but right now the shell script that invokes the python script sets some variables, and sets them to be invalid.

Moreover, I see you're checking the start version to be 8 <= version < 14, however, I don't see a reason for this upper limit, or even the lower limit. The migration script should not be limited to upgrade to v17 as far as I know. Haven't tried it yet, but even so, I think it is only reasonable to add an upper limit whenever we do find something has changed in an odoo version which our migration script doesn't handle yet. And even then, we can just 'fix' the migration script when we encounter it. As for the lower limit, why should we not allow odoo versions of 7 and lower? I can see there are OpenUpgrade scripts for odoo 5.0. Have never tried to upgrade from that version. But I think we only have a good reason (so far) to not support migrating from odoo version 3.0 and lower (since 4.0 should theoretically work).

ddejong-therp commented 9 months ago

Nevermind! It seems I forgot that that's the old ./migrate script. Everything is still in the mgirate-script branch.