search

sunfounder / Sunfounder_Smart_Video_Car_Kit_for_RaspberryPi

Sunfounder Smart Video Car Kit for Raspberry Pi
http://www.sunfounder.com
137 stars 117 forks source link

Bug and Typo fix #2

Closed agowa closed 8 years ago

agowa commented 8 years ago

In line 34 and 95 it tries to write to C:\Windows\System32\config, instead of the one in its own folder. Cause windows calls it with "C:\Windows\System32" as current directory. Now fixed ;-)

Another thing, cygwin does not have a sudo so don't call it on windows (or provide a dummy sudo.bat file with content "start %*")

sunfounder commented 8 years ago

Thanks for your pull request, but we are so sorry that, we wrote these code for Linux, not for Windows. So we could not merge your codes.

agowa commented 8 years ago

I don't see any conflicts with it, the only thing changed is a cd into the script dir and a os detection before calling the command with sudo, so on windows it's called without sudo. So now it also works on Windows ;-)

sunfounder commented 8 years ago

We test your code from your fork. It didn't work well on Windows 7. We could not sent the config file to Raspberry Pi. We might do more test on Windows, and try to fix the compatible with windows