search

sunfuze / egg-knex

knex plugin for egg
MIT License
57 stars 15 forks source link

Removed semicolon from rollback #13

Closed cemremengu closed 6 years ago

cemremengu commented 6 years ago

First of all, I am not sure if this breaks anything for other database implementations.

However, ROLLBACK; (with semicolon) causes ROLLBACK; - ORA-02181: invalid option to ROLLBACK WORK for oracle database (I am using 12c).

codecov-io commented 6 years ago

Codecov Report

Merging #13 into master will increase coverage by 0.66%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   74.83%   75.49%   +0.66%     
==========================================
  Files           5        5              
  Lines         151      151              
==========================================
+ Hits          113      114       +1     
+ Misses         38       37       -1
Impacted Files Coverage Δ
lib/knex.js 78.99% <100%> (+0.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ddff37...a47b955. Read the comment docs.

cemremengu commented 6 years ago

Added a test and looks like it doesn't break existing functionality 👍