Open sunga12 opened 11 months ago
Hi @sunga12 and @Elerqsousy ,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
✔️ Added correct info and link on the issue link. ✔️ Created tasks on the Kanban board based on the project requirements.
[x] @Team great work adding a task to handle the recipes list, but in the description, you forgot to highlight that `if the user is the owner of the recipe, the user can delete the recipe.
[x] @Team Great work adding a task to handle the login and registration of the user kindly consider specifying in the description that the pages are built with Devise.
Check the comments under the review.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @sunga12 and @Elerqsousy,
✔️ Tasks are properly assigned
Your project is complete! There is nothing else to say other than... it's time to go ahead with the project :shipit: Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
We are a team of 2 members @sunga12 and @Elerqsousy
Kanban board with all the tasks according the requirements