sungshon / PimpMyStremio

Local add-on manager for Stremio
MIT License
381 stars 51 forks source link

Add 5 new addons #76

Closed jlvcm closed 4 years ago

jlvcm commented 4 years ago

Just added some compatibility with PimpMyStream for my addons

sungshon commented 4 years ago

Oh wow, thanks.

A few mentions though, you will need to create a github release for each repository / addon (you don't need to attach any files, just set a unique tag version for them)

PimpMyStremio uses the releases to download to the users, and every time you make changes and want to update to the users, simply make a new release.

Another thing is that it might be a good idea to use the PimpMyStremio internal proxy for iptvOrg, it makes more streams work usually because it handles some header requirements. (like CORS, etc)

To use the proxy, just do:

const { proxy } = require('internal')

And then on this line: https://github.com/jlvcm/stremio-ptiptv/blob/master/addon.js#L104

Change it to:

            url: proxy.addProxy(stream)

I think this might increase stream playback success.

I'll test your addons tomorrow to make sure they work and merge if they do.

sungshon commented 4 years ago

Oh, one more mention, I think YTS only has movies, it does not have series, so it should be changed to:

        "types": ["Movies"],

in the Pull Request.

jlvcm commented 4 years ago

changed IPTV, fixed the YTS typo and added releases, thanks @sungshon, let em know if something does not work or needs fixing

sungshon commented 4 years ago

I've had a chance to test your addons, the only one that does not work is YTS, which gives an error because the node-cache module is missing, PimpMyStremio addons are limited to only these modules: https://github.com/sungshon/PimpMyStremio/blob/master/docs/modules-whitelist.md

The other 4 addons all work fine. If you want to test the addons yourself, there are 2 ways of doing this:

I just used the second method, although I can guarantee that if you use only the default modules in the YTS addon too, it will certainly just work, just mentioned the addon testing methods for future reference if you need them.

sungshon commented 4 years ago

Oh, don't forget to make another release for YTS after you made the changes. :)

pakamoon commented 4 years ago

I've made a PR to YTS to fix compatibility to PimpMyStremio, as @sungshon mentioned, you should also make a new release for YTS after merging that PR.

jlvcm commented 4 years ago

done, thanks @sungshon and @pakamoon

sungshon commented 4 years ago

yup, works fine now, merging