sungyeonu / animal-crossing-scraper

Web scraper for Animal Crossing - New Horizons data using bs4
37 stars 11 forks source link

feat: add scraping of fossils page #2

Closed Ma-ve closed 4 years ago

Ma-ve commented 4 years ago
Ma-ve commented 4 years ago

in line141 - 142, you should assign the list of fossils in fossilList, not fishList. Could you fix?

Done: https://github.com/sungyeonu/animal-crossing-scraper/pull/2/commits/291c7a23dd8cecc6ade9b82842bcf09aebab3d18

Ma-ve commented 4 years ago

If you'd like to see any changes, please do share. Python is def not my native language.

sungyeonu commented 4 years ago

Great! Thanks for quick response. I appreciate your work 🚀

I will update readme to reflect the changes soon as well.