search

sunitparekh / data-anonymization

Want to use production data for testing, data-anonymization can help you.
MIT License
459 stars 92 forks source link

update activerecord and activesupport to 6.1 #77

Closed vkostyrka closed 2 years ago

vkostyrka commented 3 years ago

Update rails 6.1 Update composite_primary_keys to 13

sidane commented 2 years ago

Would very much welcome this update @sunitparekh as it's blocking a Rails upgrade on one of my projects.

One comment on this PR @vkostyrka - it looks like the second commit has used a linting tool to modified nearly all the files in this repo. Would it be possible to update this PR to modify just the relevant gem files?

vkostyrka commented 2 years ago

Would very much welcome this update @sunitparekh as it's blocking a Rails upgrade on one of my projects.

One comment on this PR @vkostyrka - it looks like the second commit has used a linting tool to modified nearly all the files in this repo. Would it be possible to update this PR to modify just the relevant gem files? Yeah, one second

sidane commented 2 years ago

@sunitparekh any update on whether you'll consider this PR? Would be great to get it merged as it's an ongoing blocker for one of my projects.

Thanks.

sidane commented 2 years ago

Thanks for merging @sunitparekh. Will you be releasing a new version of the gem with this change?

sunitparekh commented 2 years ago

sure... I will do it over the weekend.

On Fri, Jan 7, 2022 at 3:39 PM sidane @.***> wrote:

Thanks for merging @sunitparekh https://github.com/sunitparekh. Will you be releasing a new version of the gem with this change?

— Reply to this email directly, view it on GitHub https://github.com/sunitparekh/data-anonymization/pull/77#issuecomment-1007287364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABLNORCC43RIIGT2VTY6GLUU23U7ANCNFSM5CXA4H4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- thanks & regards, Sunit Parekh +91 99237 00662 @.***

sidane commented 2 years ago

sure... I will do it over the weekend.

Hi @sunitparekh, I'm just wondering if you have any update on when you hope to release the new gem version?

Thanks.

sunitparekh commented 2 years ago

Done. Pushed version 0.8.6.

On Thu, Jan 13, 2022 at 3:13 PM sidane @.***> wrote:

sure... I will do it over the weekend.

Hi @sunitparekh https://github.com/sunitparekh, I'm just wondering if you have any update on when you hope to release the new gem version?

Thanks.

— Reply to this email directly, view it on GitHub https://github.com/sunitparekh/data-anonymization/pull/77#issuecomment-1011964220, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABLNOSA2PGW5UTQJBG2FHLUV2NDHANCNFSM5CXA4H4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- thanks & regards, Sunit Parekh +91 99237 00662 @.***

sidane commented 2 years ago

Thanks @sunitparekh 🙏