search

sunitparekh / data-anonymization

Want to use production data for testing, data-anonymization can help you.
MIT License
459 stars 92 forks source link

Upgrade activerecord and activesupport to ~> 7.1 #86

Closed sidane closed 7 months ago

sidane commented 7 months ago

This includes removing composite_primary_keys gems as a dependency. ActiveRecord 7.1 now has built-in support for composite primary keys.

The only change this required was calling ActiveRecord's primary_key class method instead of composite_primary_keys's primary_keys method.

sidane commented 7 months ago

@sunitparekh would it be possible to get a review of this at your earliest convenience?

It will help me unblock a Rails 7.1 upgrade 🙏

sidane commented 7 months ago

Many thanks @sunitparekh. Will you be releasing an updated gem?

sunitparekh commented 7 months ago

Yes, give me a day.

On Wed, Mar 20, 2024 at 3:33 PM sidane @.***> wrote:

Many thanks @sunitparekh https://github.com/sunitparekh. Will you be releasing an updated gem?

— Reply to this email directly, view it on GitHub https://github.com/sunitparekh/data-anonymization/pull/86#issuecomment-2009179242, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABLNOS7DRXDPDW6FKOSGF3YZFNIDAVCNFSM6AAAAABE6DCRUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGE3TSMRUGI . You are receiving this because you were mentioned.Message ID: @.***>

-- thanks & regards, Sunit Parekh +91 99237 00662 @.***

sunitparekh commented 7 months ago

Done.. published !!!

On Wed, Mar 20, 2024 at 4:46 PM Sunit Parekh @.***> wrote:

Yes, give me a day.

On Wed, Mar 20, 2024 at 3:33 PM sidane @.***> wrote:

Many thanks @sunitparekh https://github.com/sunitparekh. Will you be releasing an updated gem?

— Reply to this email directly, view it on GitHub https://github.com/sunitparekh/data-anonymization/pull/86#issuecomment-2009179242, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABLNOS7DRXDPDW6FKOSGF3YZFNIDAVCNFSM6AAAAABE6DCRUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZGE3TSMRUGI . You are receiving this because you were mentioned.Message ID: @.***>

-- thanks & regards, Sunit Parekh +91 99237 00662 @.***

-- thanks & regards, Sunit Parekh +91 99237 00662 @.***

sidane commented 7 months ago

Thank you @sunitparekh 🙏