sunjay / turtle

Create Animated Drawings in Rust
http://turtle.rs
Mozilla Public License 2.0
561 stars 53 forks source link

Implement #25: Add an examples index #197

Closed PaulDance closed 4 years ago

PaulDance commented 4 years ago

Hello again @sunjay!

In order to address #25, I compiled a selection of examples I judged interesting and organized them in sections by level, which I thought could be better than repeating the level for every entry, and yes also because it was simpler for me. I say that because I had quit the trouble recording the examples, then cutting and finally rendering them to GIFs, so I might have cut some corners here and there :weary:.

You might notice that I did not respect your initial proposition about some of the examples' level: I considered "Beginner" as simple geometric shapes, "Intermediate" more complex geometric constructions including drawings with parameterized arcs because I consider this just a lot of guesswork, and "Advanced" the maze and fractals drawn using recursive algorithms. So to summarize, I grouped by programming complexity rather than drawing complexity, which I think is more a matter of finding the right numbers and writing a lot of similar code. Let me know what you think about this.

Finally, I wrote the descriptions after making all those GIFs, so they did not end up being novels, but I might have included some typos, so proofreading is required.

Cheers, Paul.

codecov[bot] commented 4 years ago

Codecov Report

Merging #197 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   60.78%   60.78%           
=======================================
  Files          40       40           
  Lines        2637     2637           
=======================================
  Hits         1603     1603           
  Misses       1034     1034           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce7eb4a...0048ce0. Read the comment docs.

PaulDance commented 4 years ago

I am excited to merge it.

Nice!

Did you also speed up some of the GIFs as well?

I actually sped up the long drawings themselves using turtle.set_speed :wink:

Did you by any chance record the GIFs with a red-light filter enabled or some other program that makes your screen dimmer?

Oopsie daisy :man_shrugging:... yes I did, but it never crossed my mind! I guess this is how one learns, huh.

If you have a chance, could you try and re-record the heart and maze examples?

Yes I can definitely do that and truthfully I think it would look better to have them all in the same size. The time I spent recording and adjusting the GIFs was mostly figuring out how to get the GIFs themselves first. I tried using Peek, but couldn't make it work because moving and resizing the recording window was a nightmare. So i used recordMyDesktop that I have used before and worked fine, but when I tried to edit the result using the graphical video editor kdenlive, exporting to a GIF was a complete failure. So I finally had to make the edits manually with ffmpeg which I never used before... Now, it shouldn't take me that much time to record two additional ones, no worries.

PaulDance commented 4 years ago

@sunjay That should be it, right?

sunjay commented 4 years ago

@PaulDance I just applied the last suggestion that must have been missed for some reason. I'll merge as soon as the build passes. Nicely done! 🎉

PaulDance commented 4 years ago

@sunjay No, I did not miss that one: you came back on your first comment saying this part was actually fine by you, so I let it as is. Did I miss something?

sunjay commented 4 years ago

@PaulDance I think there may have been some misunderstanding. The suggestion I just applied was similar to several others you applied earlier, not one of the ones we discussed leaving as is. Is there a comment where I said it was fine as is?

PaulDance commented 4 years ago

See the links I just added to my previous message. Know that I am fine with your changing it, but I thought you changed your mind and wanted to leave it in.

sunjay commented 4 years ago

Ah! I see where the misunderstanding is. Here's the comment you linked to with some added emphasis:

Note that despite my earlier comment, I am totally fine with using "simple" in the example titles for these shapes. That is a totally accurate description of the drawing and doesn't have anything to do with the example code itself. :)

So you see, I'm fine with calling the shapes themselves simple, but I wanted to change the description to avoid calling the example that. (My other comment that makes the applied suggestion goes more into why.)

Sorry for the confusion! Hopefully that resolves things and we can get this merged. 😁

PaulDance commented 4 years ago

Ok then, sorry I missed that part. Everything is therefore fine by me now. You'll be able to merge this in a few minutes I'd say.

sunjay commented 4 years ago

Great job @PaulDance!