sunjay / turtle

Create Animated Drawings in Rust

http://turtle.rs

Mozilla Public License 2.0

559 stars 54 forks source link

Implement #13: Ferris example #200

Closed PaulDance closed 3 years ago

PaulDance commented 3 years ago

Heyo @sunjay! I finished the Ferris example proposed in #13, but with the "happy" version as we discussed, I think it looks quite good. I have put documentation and an example index entry as well.

Slight downside however: I tried to make it independent of canvas dimensions by distorting the curves, but it wasn't a complete success for the shell spikes. I explained in the comments why that is. With the default window size it works as expected of course. Let me know what you think.

Cheers, Paul.

codecov[bot] commented 3 years ago

Codecov Report

Merging #200 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   60.78%   60.78%           
=======================================
  Files          40       40           
  Lines        2637     2637           
=======================================
  Hits         1603     1603           
  Misses       1034     1034

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37ca9e7...f3f7fd7. Read the comment docs.

sunjay commented 3 years ago

Oh and it looks like you need to rebase off of the latest master. Please do that when you have a chance. :)

PaulDance commented 3 years ago

It looks fantastic overall!

I'm glad it does! :smile:

Please feel free to take a look at it again yourself and make any further improvements you deem necessary.

I tried my best to make it interesting, however, the approach I took was safe but quite boring and disappointing in the end :cry:... So I don't think I'm going to try to improve it in the near future, as it would require changing various things. But maybe some day I'll have a revelation and make it perfect with a magic wand, who knows.

I'm ready to merge when you are.

I am: I have applied the suggestions you pointed out.

Thanks for continuing to produce really high quality PRs!

No problem, I have not done this much yet, so I find it quite fun, and more are coming! :wink:

sunjay commented 3 years ago

Thanks @PaulDance! 🎉

sunjay commented 3 years ago

And congrats on getting PR #200! That's a big milestone! 🎉 🎉 🎉