sunjay / turtle

Create Animated Drawings in Rust
http://turtle.rs
Mozilla Public License 2.0
559 stars 54 forks source link

Implement #82: Add an arc method #206

Closed PaulDance closed 3 years ago

PaulDance commented 3 years ago

This is part of #82 by following the mentoring instructions. However, only the part 1 is covered in the current state, hence the draft. Part 2 will be implemented when the intermediate review is finished and adequate instructions completed.

Steps of the issue that have been covered:

The documentation looks like this for now:

image image image image

As a general comment, the overall structure should be satisfying, it is quite simple after all. However, the current implementation interestingly performs very poorly: it is imprecise, very slow, laggy and gets worse over time. That could be caused by a mistake or just by the simplistic algorithm used that generates hundreds of IPC requests. Either way, it is definitely not the intended final state.

codecov[bot] commented 3 years ago

Codecov Report

Merging #206 into master will increase coverage by 0.70%. The diff coverage is 85.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   60.81%   61.51%   +0.70%     
==========================================
  Files          40       40              
  Lines        2636     2697      +61     
==========================================
+ Hits         1603     1659      +56     
- Misses       1033     1038       +5     
Impacted Files Coverage Δ
src/async_turtle.rs 77.77% <62.50%> (-1.79%) :arrow_down:
src/ipc_protocol/protocol.rs 55.33% <66.66%> (+0.51%) :arrow_up:
src/turtle.rs 92.56% <100.00%> (+2.27%) :arrow_up:
src/point.rs 58.82% <0.00%> (+2.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 960049a...20fef67. Read the comment docs.

sunjay commented 3 years ago

Please also rebase this branch when you get a chance. :)