search

sunjay / turtle

Create Animated Drawings in Rust
http://turtle.rs
Mozilla Public License 2.0
561 stars 53 forks source link

Reformat codebase using standard style #209

Closed PaulDance closed 3 years ago

PaulDance commented 3 years ago

As recently discussed, the current codebase declares a non-standard style in its .rustfmt.toml configuration file. However, that style is not used, as running cargo fmt changes a lot of files. Therefore this PR removes the rustfmt configuration and reformats the whole codebase. As an additional feature, a style check has been added to the CI jobs in order to enforce and normalize a project style. CONTRIBUTING.md has been updated accordingly.

codecov[bot] commented 3 years ago

Codecov Report

Merging #209 into master will decrease coverage by 1.67%. The diff coverage is 45.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   61.51%   59.83%   -1.68%     
==========================================
  Files          40       40              
  Lines        2697     2846     +149     
==========================================
+ Hits         1659     1703      +44     
- Misses       1038     1143     +105
Impacted Files Coverage Δ
src/debug.rs 0.00% <ø> (ø)
src/event.rs 0.00% <0.00%> (ø)
src/point.rs 58.82% <ø> (ø)
src/radians.rs 80.95% <ø> (ø)
src/rand.rs 53.48% <ø> (ø)
src/renderer_server/app.rs 50.00% <0.00%> (-11.12%) :arrow_down:
src/renderer_server/backend/multiprocessed.rs 0.00% <0.00%> (ø)
src/renderer_server/backend/multithreaded.rs 0.00% <0.00%> (ø)
src/renderer_server/event_loop_notifier.rs 0.00% <ø> (ø)
src/renderer_server/handlers/create_turtle.rs 100.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdac20c...cec6cdf. Read the comment docs.

sunjay commented 3 years ago

Hi Paul, I'm still not satisfied with rustfmt's current formatting. I'll re-evaluate using it in a couple of months. Please try to be patient until then.