search

sunjay / turtle

Create Animated Drawings in Rust
http://turtle.rs
Mozilla Public License 2.0
559 stars 54 forks source link

Do not use eq on floats #229

Closed enaut closed 3 years ago

enaut commented 3 years ago

As clippy suggests it is not a good idea to directly compare floats using eq (or ==).

sunjay commented 3 years ago

I'll merge once the build passes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #229 (f234e66) into master (006e2f6) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   61.21%   61.21%           
=======================================
  Files          40       40           
  Lines        2697     2697           
=======================================
  Hits         1651     1651           
  Misses       1046     1046
Impacted Files Coverage Δ
src/color.rs 96.85% <100.00%> (ø)
src/turtle.rs 92.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 006e2f6...f234e66. Read the comment docs.