sunjay / turtle

Create Animated Drawings in Rust
http://turtle.rs
Mozilla Public License 2.0
559 stars 54 forks source link

Battleship board game implementation in Turtle #246

Open sathwikmatsa opened 2 years ago

sathwikmatsa commented 2 years ago

This PR adds battleship board game implementation to turtle examples - #23

enaut commented 2 years ago

Firstly - I don't have commit rights here!

I did not really read the whole code. But at a first glance, I think it would be nice to have some more documentation - as the examples are made to be read for learning. The audience is less experienced and is often very happy for explaining comments - so an overview in main.rs over the code might be helpful, as well as some function documentations for the less obvious things...

That said, the game itself looks great!

sathwikmatsa commented 2 years ago

Hey @enaut, Thanks for your feedback. I've added some documentation as per your suggestion. Let me know if you have any comments.

sunjay commented 2 years ago

Thanks for taking the time to contribute this example! Appreciate the first pass at reviewing @enaut. I have been swamped with things at work lately but hopefully I will have time to review this in the coming week. If I don't get to it by next weekend, please ping me. Sorry for the delay!