sunjay / turtle

Create Animated Drawings in Rust
http://turtle.rs
Mozilla Public License 2.0
562 stars 53 forks source link

Test Windows Support #26

Closed sunjay closed 6 years ago

sunjay commented 7 years ago

As far as I know, there is nothing platform specific in the code. That being said, is a good idea to check if the examples run on Windows. We already test the build on Windows using appveyor. We just want to make sure the examples look and feel how they should on all platforms.

sunjay commented 7 years ago

At least on VirtualBox, this fails with the following error:

$ RUST_BACKTRACE=1 cargo run --example circle
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running `target\debug\examples\circle.exe`
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "Co                                                                                                                                                                                               uldn\'t find any pixel format that matches the criterias."', src\libcore\result.                                                                                                                                                                                               rs:906:4
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose bac                                                                                                                                                                                               ktrace.
stack backtrace:
   0: std::sys_common::backtrace::_print
             at C:\projects\rust\src\libstd\sys_common\backtrace.rs:94
   1: std::panicking::default_hook::{{closure}}
             at C:\projects\rust\src\libstd\panicking.rs:380
   2: std::panicking::default_hook
             at C:\projects\rust\src\libstd\panicking.rs:397
   3: std::panicking::rust_panic_with_hook
             at C:\projects\rust\src\libstd\panicking.rs:611
   4: std::panicking::begin_panic<alloc::string::String>
             at C:\projects\rust\src\libstd\panicking.rs:572
   5: std::panicking::begin_panic_fmt
             at C:\projects\rust\src\libstd\panicking.rs:522
   6: std::panicking::rust_begin_panic
             at C:\projects\rust\src\libstd\panicking.rs:498
   7: core::panicking::panic_fmt
             at C:\projects\rust\src\libcore\panicking.rs:71
   8: core::result::unwrap_failed<alloc::string::String>
             at C:\projects\rust\src\libcore\macros.rs:41
   9: core::result::Result<piston_window::PistonWindow<glutin_window::GlutinWind                                                                                                                                                                                               ow>, alloc::string::String>::unwrap<piston_window::PistonWindow<glutin_window::G                                                                                                                                                                                               lutinWindow>,alloc::string::String>
             at C:\projects\rust\src\libcore\result.rs:772
  10: turtle::renderer::Renderer::run
             at .\src\renderer.rs:71
  11: turtle::turtle_window::{{impl}}::new::{{closure}}
             at .\src\turtle_window.rs:80

This seems to be an issue in piston

sunjay commented 6 years ago

This works on Windows! Tested on Windows 10 (not through virtual box or something)