sunjc826 / pe

0 stars 0 forks source link

Lacking input validation for list #6

Open sunjc826 opened 3 years ago

sunjc826 commented 3 years ago

Issue description

Since only alphanumeric chars are allowed for GAME_ID, I should not expect other characters to be a valid search character, since it will never match anything.

Steps to reproduce the issue

List with game --list --

What's the expected result?

Error message restricting dashes in a search keyword.

What's the actual result?

No error is given and no game matches

Additional details

Reason for severity: Having validations can improve the user experience.

nus-pe-bot commented 2 years ago

Team's Response

Rationale

This is intended by design, as there is no reason to limit the keyword, as mentioned, it will not match anything, and the expected result will just be empty. eg. This behavior also happens for many other products and is not a bug - such as the module website:

The user has no reason/purpose to filter weird characters that do not even exist in the game id or the friend id. If they do, they should expect to see nothing, as they have no friend id or game ids with these weird characters.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

[ ] I disagree

Reason for disagreement: [replace this with your explanation]