sunjw / jstoolnpp

A JavaScript (JSON) tool for Notepad++ (formerly JSMinNpp) and Visual Studio Code.
GNU General Public License v2.0
281 stars 24 forks source link

Plugin package hash missmachted #76

Closed pschneider87 closed 4 years ago

pschneider87 commented 5 years ago

I want to install JSTool from the PluginManager in Notepad++, but constantly getting an hash-error

image

Also directly placing the "JSMinNPP.dll" into the plugin folder won't bring me the JSTool in N++

Any ideas?

sunjw commented 5 years ago

Npp has its own "Plugins Admin", JSTool has been moved to it now. This 1.1905.1 in "Plugin Manager" is not submitted by me, I'll check.

sunjw commented 5 years ago

@chcg I found that you are maintaining Plugin Manager. Would you please check the data?

chcg commented 5 years ago

@sunjw The output above is not from PluginManager which still uses md5 checksums (https://github.com/bruderstein/npp-plugins-x64/blob/master/plugins/validate.json#L97), but from N++ builtin PluginsAdmin (sha256 hash, see https://github.com/notepad-plus-plus/nppPluginList/blob/master/src/pl.x64.json#L270 from https://github.com/notepad-plus-plus/nppPluginList/commit/4286be61d298947cdfc19c357d61b01920743a73).

Just downloaded it manually and checked sha256 hash and is still 338cf91653094746452f344ed0e25dc11fe48bf1de3fe4fb41e20a44927f905b. Also the appveyor CI checks which contain a download of all plugins with a check of the hashes are still working fine. So either the zip packages was somehow modified during download or locally or the used download component https://github.com/notepad-plus-plus/wingup has a bug.

@pschneider87 could you please provide the N++ debug infos of the version you are using.

sunjw commented 5 years ago

Hi @chcg Thanks very much. And '338cf91653094746452f344ed0e25dc11fe48bf1de3fe4fb41e20a44927f905b' is the correct checksum.

pschneider87 commented 5 years ago

@chcg sure, here you go:

Notepad++ v7.7.1 (64-bit) Build time : Jun 16 2019 - 21:24:47 Path : C:\Program Files\Notepad++\notepad++.exe Admin mode : OFF Local Conf mode : OFF OS : Windows 10 (64-bit) Plugins : DSpellCheck.dll LanguageHelp.dll mimeTools.dll NppConverter.dll NppExport.dll NPPJSONViewer.dll NppSaveAsAdmin.dll XMLTools.dll

psined1 commented 4 years ago

Hi, any update on this one? MD5 still looks broken, both for Notepad++ v7.8 in x86 and x64

chcg commented 4 years ago

@psined1 @pschneider87

I can't reproduce the issue with builtin PluginAdmin of N++:

Notepad++ v7.8   (64-bit)
Build time : Oct  4 2019 - 00:19:37
Path : C:\Users\chcg\npp.7.8.bin.x64\notepad++.exe
Admin mode : OFF
Local Conf mode : ON
OS Name : Windows 10 Home (64-bit) 
OS Version : 1903
OS Build : 18362.418
Plugins : BigFiles.dll DSpellCheck.dll JSMinNPP.dll mimeTools.dll NppConverter.dll NppExport.dll PythonScript.dll 

To add the dll manually since 7.6.x it need to be placed under

...\Notepad++\plugins\JSMinNPP\JSMinNPP.dll

Also with 7.7.1 32bit and 64bit I see issue.

chcg commented 4 years ago

@sunjw Could you please check the ssl certificate of https://www.sunjw.us/ seems it expired on 13.8.2019.

sunjw commented 4 years ago

@sunjw Could you please check the ssl certificate of https://www.sunjw.us/ seems it expired on 13.8.2019.

Hi @chcg my web host doesn't support HTTPS and I don't even know why they open 443 port. Also, I tested to accept the certificate, then it shown an 404 page.

sunjw commented 4 years ago

@sunjw Could you please check the ssl certificate of https://www.sunjw.us/ seems it expired on 13.8.2019.

Hi @chcg my web host doesn't support HTTPS and I don't even know why they open 443 port. Also, I tested to accept the certificate, then it shown an 404 page.

Oh... I found that my web hoster (aliyun) supports HTTPS for my product now, I'll enable HTTPS access soon. But currently, HTTPS://www.sunjw.us is not HTTPS of my site. The plugin is download from sf.net with HTTPS, I cannot see why the checksum is not right. I can only guess that file is partially downloaded. Counld @psined1 @pschneider87 do a check with my fHash https://github.com/sunjw/fhash, then give us a screenshot of fHash result.