Closed tamimuiuc closed 6 months ago
Hello,
I've completed the requested changes and there are no conflicts with the base branch. Could you please confirm the next steps for merging this pull request? Do I need to take any further action?
Additionally, I would like to confirm that this contribution meets the requirements for the 10 bonus points as outlined in the course instructions. If there is any additional information or action needed from my side, please let me know.
Thank you!
Hi @tamimuiuc , thanks for your PR. I have started to test your PR locally.
stat()
function.
Hello, I have carefully reviewed your PR.
We will give partial bonus points based on this.
@ycq091044 Thank you for your feedback. Actually, the XGBClassifier uses:
Y, I can quickly make it run. There are just some minor bugs, such as XGBClassifier is not imported anywhere.
Hi, in 'xgboost.py', I did 'import xgboost as xgb' and created 'XGBoostModel' class. Also, in 'mortality_mimic3_sepsis3.py', I did both 'import xgboost as xgb' and called 'XGBoostModel'. You should be able to run the classifier successfully.
WHERE DID YOU IMPORT XGBoostModel in mortality_mimic3_sepsis3.py?
I see, you are right. I compiled all the code in Google Colab and ran it there. I did not import XGBoostModel.Thank you!
Mohammad Tamim tamim2@illinois.edu
Pull Request - Addition of Sepsis-3 Mortality Prediction Models and Datasets
This pull request includes several components that extend PyHealth's capabilities for analyzing mortality in sepsis patients using the MIMIC-III dataset.
Changes include:
datasets/mimic3_sepsis3.py
: A dataset script for preprocessing sepsis-related data.tasks/mortality_prediction_sepsis3.py
: A task definition for mortality prediction.models/xgboost.py
: An XGBoost model tailored for predicting mortality.examples/mortality_mimic3_sepsis3.py
: An example script demonstrating the workflow from data loading to prediction.I've tested these additions with data from the MIMIC-III public dataset, focusing on ensuring compatibility and performance within the existing PyHealth framework.
I welcome any feedback on code style, performance improvements, or integration aspects. Thank you for considering this contribution!