search

sunlightlabs / congress-ios

iOS app for tracking and contacting your legislators, and learning about new bills and laws.
http://congress.sunlightfoundation.com
Other
46 stars 22 forks source link

Geolocation "search" of legislators #184

Closed dcloud closed 11 years ago

dcloud commented 11 years ago

For this I'm thinking a geo icon on the right side of the nav bar in the legislator's list view that you click, making it selected/highlighted, and a semitranslucent overlay appears to cover the existing view and shows activity indicator spinning while it looks up legislators for your location, then shows a list of legislators. You could go to their detail pages from there, but to get out, you'd need to touch the geo icon again.

Looking at the UIBarButtonSystemItem list, I don't see an apple built-in icon. We may need to make our own, I guess. Need to research that, though I feel like a circle/target icon is pretty much standard.

nickom commented 11 years ago

Perhaps we could just steal the one we used for Sitegeist?

On Fri, May 24, 2013 at 5:24 PM, Daniel Cloud notifications@github.comwrote:

For this I'm thinking a geo icon on the right side of the nav bar in the legislator's list view that you click, making it selected/highlighted, and a semitranslucent overlay appears to cover the existing view and shows activity indicator spinning while it looks up legislators for your location, then shows a list of legislators. You could go to their detail pages from there, but to get out, you'd need to touch the geo icon again.

Looking at the UIBarButtonSystemItem list, I don't see an apple built-in icon. We may need to make our own, I guess. Need to research that, though I feel like a circle/target icon is pretty much standard.

— Reply to this email directly or view it on GitHubhttps://github.com/sunlightlabs/congress-ios/issues/184 .

nickom commented 11 years ago

https://github.com/sunlightlabs/sitegeist-ios/blob/master/Resources/Images/74-location.png and https://github.com/sunlightlabs/sitegeist-ios/blob/master/Resources/Images/74-location%402x.png

?

jcarbaugh commented 11 years ago

Briefly discussed this with Daniel, so adding more here.

I had the same idea on the placement of the locator button, but I think the screen should display within the navigation flow and not in a modal. This is a screen that people will go into legislator detail views from and then want to come back. Going from navigation -> modal -> navigation and back again is weird. I've done mockups of two different ideas.

geo-legislators-1

The first adds the locator button to the navigation bar. When clicked, it pushes a new view onto the navigation stack. This view has a map centered on current location (with droppable pin to relocate) and a list of the local legislators. The back button returns you to the legislator list.

geo-legislators-2

The second collapses this down into the legislator list screen. The locator button is added to the right of the segment toggles. Clicking it adds the same map view and list in the previous example, but as a sub view of the existing list.

Thoughts?

nickom commented 11 years ago

Personally I like the first mock up a lot more.

In the map view, I assume that's loading in the overlay of the district you're in? Displaying that may be awkward since it's also showing Senators and I can imagine issues if there's a weird GPS signal (which district does it load if you're on the border, etc?). Doing a map view without overlays would probably be easier to implement and a cleaner view in my opinion, plus once it loads your members you can click through to see the district shape.

On Tue, May 28, 2013 at 12:25 PM, Jeremy Carbaugh notifications@github.comwrote:

Briefly discussed this with Daniel, so adding more here.

I had the same idea on the placement of the locator button, but I think the screen should display within the navigation flow and not in a modal. This is a screen that people will go into legislator detail views from and then want to come back. Going from navigation -> modal -> navigation and back again is weird. I've done mockups of two different ideas.

[image: geo-legislators-1]https://f.cloud.github.com/assets/39159/573523/e28219dc-c7b2-11e2-9292-5913e63c848b.png

The first adds the locator button to the navigation bar. When clicked, it pushes a new view onto the navigation stack. This view has a map centered on current location (with droppable pin to relocate) and a list of the local legislators. The back button returns you to the legislator list.

[image: geo-legislators-2]https://f.cloud.github.com/assets/39159/573530/17227376-c7b3-11e2-9e82-c2eac6498d57.png

The second collapses this down into the legislator list screen. The locator button is added to the right of the segment toggles. Clicking it adds the same map view and list in the previous example, but as a sub view of the existing list.

Thoughts?

— Reply to this email directly or view it on GitHubhttps://github.com/sunlightlabs/congress-ios/issues/184#issuecomment-18562264 .

dcloud commented 11 years ago

I also like the first mockup more. I will get over my navbar non-modal button phobia. I disagree with @nickom on the issue of districts in the map view. I think it is useful to see district outlines, particularly if you are seeing results other than what you expect. I don't think it awkward to show Senators, and I'm for the completeness of "all your legislators". We could separate the them from Reps into different sections in the table (instead of by last initial), with titles like "Your representative" and "You senators".

jcarbaugh commented 11 years ago

I really have no preference between the two... I'm on the edge of my seat waiting for @cweber's opinion.

I'm with Daniel on the district shape though. I think it is useful for context and, even though Senators represent OTHER districts as well, they are the representatives of the shown district too. It's also useful to see who else (city/location-wise) is represented by the same legislators.

nickom commented 11 years ago

I guess I'm thinking of situations where you straddle two districts and your GPS isn't 100% accurate. Also what happens if you drop a pin in a new spot, does it just keep illuminating/loading the new district overlay? Curious to see how responsive it is to load new districts. If that's not an issue then let's show the district. I probably should wait to do bug testing/reporting before the feature exists...

I keep thinking of: img_8638

jcarbaugh commented 11 years ago

I don't even know if it would be possible to straddle two districts. You'd have to have a very, very precise floating point number to fall EXACTLY on a district line. I think that even if you fell exactly on a vertex of a shape, you'd still be considered part of that shape. That would be something to test on boundary service, but it should be considered an extreme edge case.

If you drop a new location outside of the current district, I'd see the map updating to show the new district. Performance should be fine... almost exactly the same as viewing a legislator bio view (without having map tiles reload).